fix llm streaming #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚀 Preview Deployments Ready!Your changes have been deployed to preview environments: 📦
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="openrouter/server/tools/llm-binding.ts">
<violation number="1" location="openrouter/server/tools/llm-binding.ts:471">
P2: Use `APICallError.isInstance(error)` instead of a custom symbol-based type guard. The AI SDK provides this static method specifically for type checking, and relying on internal symbols (`Symbol.for('vercel.ai.error')`) is fragile and could break with SDK updates.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Comment on lines
+471
to
+475
| const isAPICallError = (error: unknown): error is APICallError => | ||
| typeof error === "object" && | ||
| error !== null && | ||
| Symbol.for("vercel.ai.error") in error && | ||
| Symbol.for("vercel.ai.error.AI_APICallError") in error; |
There was a problem hiding this comment.
P2: Use APICallError.isInstance(error) instead of a custom symbol-based type guard. The AI SDK provides this static method specifically for type checking, and relying on internal symbols (Symbol.for('vercel.ai.error')) is fragile and could break with SDK updates.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At openrouter/server/tools/llm-binding.ts, line 471:
<comment>Use `APICallError.isInstance(error)` instead of a custom symbol-based type guard. The AI SDK provides this static method specifically for type checking, and relying on internal symbols (`Symbol.for('vercel.ai.error')`) is fragile and could break with SDK updates.</comment>
<file context>
@@ -467,6 +468,12 @@ const getUsageFromStream = (
];
};
+const isAPICallError = (error: unknown): error is APICallError =>
+ typeof error === "object" &&
+ error !== null &&
</file context>
Suggested change
| const isAPICallError = (error: unknown): error is APICallError => | |
| typeof error === "object" && | |
| error !== null && | |
| Symbol.for("vercel.ai.error") in error && | |
| Symbol.for("vercel.ai.error.AI_APICallError") in error; | |
| const isAPICallError = (error: unknown): error is APICallError => | |
| APICallError.isInstance(error); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Fixed real-time LLM streaming for OpenRouter by using the correct provider API and returning proper error responses. This prevents broken streams and surfaces accurate status, headers, and body on failures.
Bug Fixes
Dependencies
Written for commit efc81fb. Summary will update on new commits.